Record error #46
Merged
Record error #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtbc
reviewed
Jun 14, 2019
src/main/java/org/openmicroscopy/shoola/env/data/DataServicesFactory.java
Outdated
Show resolved
Hide resolved
|
Is https://github.com/ome/omero-insight/pull/46/files#diff-d3089c1dff7a3f6c789980fcb8bcb74aL581 broken? I'm starting to wonder if safest would be to put the no-"OMERO." version into a different variable for the upgrade check rather than mutating |
mtbc
reviewed
Jun 14, 2019
| try { | ||
| exp = omeroGateway.connect(cred); | ||
| } catch(Exception e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
Is this intended? (Should it go via logging?)
There was a problem hiding this comment.
no, I was trying to figure out why I could not connect to merge-ci
mtbc
approved these changes
Jun 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Record error
Check that the application still runs
cc @mtbc