roi tooltips #211
Merged
roi tooltips #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will-moore
changed the title
|
This seems to be working on web-dev-merge now (although I noticed it doesn't show Owner of first save of ROI, but does when you load the image with existing ROIs):
|
|
Looks good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://trello.com/c/gWqOfidt/61-show-better-tooltips-on-rois
This change displays the Owner of the Shape even if that is the current user or the current user is able to edit the ROI (e.g. admin). Previously we only showed owner if they couldn't edit the Shape.
Also, if the shape is unsaved, tooltip show "Unsaved" instead of showing negative ROI and Shape IDs.
To test: