Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /api/config/ to return mapr_settings.CONFIG as JSON #46

Merged
merged 1 commit into from
May 22, 2019

Conversation

will-moore
Copy link
Member

@will-moore will-moore commented Apr 29, 2019

This makes the mapr_settings.CONFIG available as JSON data, so it can be used by other apps.
E.g. ome/omero-gallery#25

To test:

Screen Shot 2019-04-29 at 15 59 50

@will-moore
Copy link
Member Author

@sbesson @manics How to get this deployed, tested & merged?
Currently I'm hard-coding this in ome/omero-gallery#25 until I can point at a server.

@manics
Copy link
Member

manics commented May 3, 2019

@jburel Gallery is on web-dev-merge.openmicroscopy.org/gallery/ can we do the same for mapr?

@jburel
Copy link
Member

jburel commented May 3, 2019

certainly

@will-moore will-moore mentioned this pull request May 9, 2019
29 tasks
@will-moore
Copy link
Member Author

Added mapr to web-dev-merge.
See http://web-dev-merge.openmicroscopy.org/mapr/api/config/

Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally tested using the CI deployment. I can confirm the behavior as described in this PR i.e.

$ curl http://web-dev-merge.openmicroscopy.org/mapr/apnfig/
{"gene": {"default": ["Gene Symbol"], "all": ["Gene Symbol", "Gene Identifier"], "ns": ["openmicroscopy.org/mapr/gene"], "label": "Gene"}, "antibody": {"default": ["Antibody Identifier"], "all": ["Antibody Identifier"], "ns": ["openmicroscopy.org/mapr/antibody"], "label": "Antibody"}}

Generally, agreed that defining an endpoint to expose the mapr configuration is a useful addition especially in the case of public deployments like IDR. As discussed, the only caveat might be a case where part of the configuration contains secure information which should not be shared.

I do not have a use case in mind but it might be worth adding an extra configuration as a follow-up allowing the selective disabling of this endpoint.

In the interim, proposing to merge and cut a 0.3.0a1 release of omero-mapr to move forward with the deployment of the new IDR UI on the testing resource.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants