Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove hdfstorageV1 (fix #40) #136

Merged
merged 1 commit into from Dec 3, 2019
Merged

Conversation

joshmoore
Copy link
Member

With the dropping of Python 2, there's no need for
a version of tables with the openFile method.

With the dropping of Python 2, there's no need for
a version of tables with the `openFile` method.
Copy link
Member

@manics manics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshmoore
Copy link
Member Author

Cheers. Debated stripping out the logic for choosing between the versions, but I figured a V3 might come along some day.

@joshmoore joshmoore merged commit ca629b9 into ome:master Dec 3, 2019
@joshmoore joshmoore deleted the drop-hdf-v1 branch December 3, 2019 10:07
@joshmoore joshmoore added this to the 5.6.0 milestone Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants