Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove f-string usage for Python 3.5 compatibility #257

Merged
merged 1 commit into from Sep 29, 2020

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Sep 29, 2020

The usage of f-strings breaks Python 3.5 compatibility which affects the ability to run OMERO on some environments. This is a minor change which restores some compatibility.

Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@joshmoore
Copy link
Member

(I also don't see other hits trying various regexes like

  492  git grep -E '[^"-a-z]f".*"'
  496  git grep -E "[^'-]f'.*'"

)

@sbesson sbesson merged commit a45dda7 into ome:master Sep 29, 2020
@sbesson sbesson deleted the python35_compatibility branch September 29, 2020 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants