Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub workflow #261

Merged
merged 2 commits into from Oct 1, 2020
Merged

Add GitHub workflow #261

merged 2 commits into from Oct 1, 2020

Conversation

manics
Copy link
Member

@manics manics commented Oct 1, 2020

I got fed up of waiting for Travis. If we decide to go this route we'll need to setup (and test) the Pypi deploy secrets, and should delete .travis.yml

@sbesson
Copy link
Member

sbesson commented Oct 1, 2020

I am getting increasingly convinced of our upcoming transition to GitHub workflows so no objection from my side. A few questions:

@joshmoore
Copy link
Member

  • Does something need to be activated?

I'm not convinced adding a workflow in a PR always works as expected (or at all?)

  • should we try a PyPI release via GitHub action for omero-py 5.8.2?

WFM.

@manics
Copy link
Member Author

manics commented Oct 1, 2020

I'm not convinced adding a workflow in a PR always works as expected (or at all?)

It usually works for me, but maybe it depends on the repo settings?

@sbesson
Copy link
Member

sbesson commented Oct 1, 2020

I am tempted in that case to trust https://github.com/manics/omero-py/actions/runs/282486285 and merge. Although we probably need to remove at least the Travis deployment step to avoid having 2 places releasing concurrently. Separate PR?

@manics
Copy link
Member Author

manics commented Oct 1, 2020

I've removed the deploy step so we can merge it and test the workflow runs as expected. I'll then add the deploy step back and remove travis in the next PR

@sbesson
Copy link
Member

sbesson commented Oct 1, 2020

👍 a general question I have is about what the name of GitHub workflow should be esp. if there is a single one. Options I can think of workflow.yml, main.yml, build.yml. This does not need ot block this PR for the reasons described above.

@sbesson sbesson merged commit b8a1341 into ome:master Oct 1, 2020
@sbesson
Copy link
Member

sbesson commented Oct 1, 2020

@manics manics deleted the ghworkflow branch October 1, 2020 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants