Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update testng to 7.5 #33

Merged
merged 1 commit into from
Dec 6, 2022
Merged

update testng to 7.5 #33

merged 1 commit into from
Dec 6, 2022

Conversation

jburel
Copy link
Member

@jburel jburel commented Feb 22, 2022

Update testng to see if fixes the error related to jcommander

sbesson
sbesson reviewed Dec 1, 2022
View reviewed changes
Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been in the build for a while and has not caused any instability correct?
Is there any downside to upgrading?

This was referenced Dec 1, 2022
Merged
Merged
@jburel
Copy link
Member Author

jburel commented Dec 2, 2022

I has not. This was part of an initial investigation when Zarr reader was first introduced.
I don't think there is any problem in upgrading it. I will have to review the other repositories since I think I closed some of the PRs

@jburel jburel merged commit 27bcdc2 into ome:master Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbesson sbesson sbesson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jburel @sbesson