Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session bean actions should happen at SYSTEM priority #176

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

chris-allan
Copy link
Member

Session bean actions should happen at SYSTEM priority so that long running user or background tasks cannot cause things like closeSession() to block for long periods of time. The Executor system thread pool is unbounded.

@sbesson
Copy link
Member

sbesson commented Mar 12, 2024

@chris-allan

diff --git a/src/test/java/ome/server/utests/sessions/SessionBeanUnitTest.java b/src/test/java/ome/server/utests/sessions/SessionBeanUnitTest.java
index a39055eb..fdf8ee8f 100644
--- a/src/test/java/ome/server/utests/sessions/SessionBeanUnitTest.java
+++ b/src/test/java/ome/server/utests/sessions/SessionBeanUnitTest.java
@@ -111,7 +111,7 @@ public class SessionBeanUnitTest extends MockObjectTestCase {
         exMock.expects(once()).method("submit").will(new Stub(){
 
             public Object invoke(Invocation arg0) throws Throwable {
-                Callable callable = (Callable) arg0.parameterValues.get(0);
+                Callable callable = (Callable) arg0.parameterValues.get(1);
                 final Object rv = callable.call();
                 return new Future() {

should update the test to match the proposed implementation changes in SessionBean and fix the unit test failures.

@chris-allan
Copy link
Member Author

Thanks, @sbesson.

@jburel jburel merged commit 82d598f into ome:master Mar 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants