Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Py3 only #103

Merged
merged 8 commits into from
Jan 9, 2020
Merged

Py3 only #103

merged 8 commits into from
Jan 9, 2020

Conversation

will-moore
Copy link
Member

Py3 only...

@joshmoore joshmoore added this to In progress in OMERO.server 5.6.0 (Python 3) via automation Dec 20, 2019
@manics
Copy link
Member

manics commented Jan 6, 2020

Looks OK to me. Is it worth bumping travis to bionic on all repos too? https://docs.travis-ci.com/user/reference/bionic/#using-ubuntu-1804-bionic-beaver

manics
manics reviewed Jan 8, 2020
View reviewed changes
Copy link
Member

@manics manics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis: ./omeroweb/settings.py:393:80: E501 line too long (80 > 79 characters)

If this is more or less the final production PR could you also add:

  • python_requires='>=3', to setup.py
  • distributions: sdist bdist_wheel to travis.yml deploy

@will-moore
Copy link
Member Author

Travis failed with

ERROR:   py27: InvocationError for command /src/.tox/py27/bin/python -m pip install --exists-action w .tox/.tmp/package/1/omero-web-5.6.dev8.zip (exited with code 1)

@joshmoore joshmoore self-requested a review January 8, 2020 14:51
@joshmoore
Copy link
Member

Looks good. Did the green re-run of OMERO-docs (https://py3-ci.openmicroscopy.org/jenkins/job/OMERO-docs/118/) include this PR?

@will-moore
Copy link
Member Author

@joshmoore I don't know if or how omeroweb/settings.py is used to generate docs omero/sysadmins/config.rst, which is why I have committed the same changes in ome/omero-documentation@7f52f76

@joshmoore
Copy link
Member

At the moment, the workflow is that to prepare the docs release, I run autogen locally and open a PR from the changes. Adding them manually yourself is fine as long as the PR gets merged before the next autogen PR gets open. Thanks!

joshmoore
joshmoore approved these changes Jan 9, 2020
View reviewed changes
Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

OMERO.server 5.6.0 (Python 3) automation moved this from In progress to Reviewer approved Jan 9, 2020
@joshmoore joshmoore merged commit b6cfa60 into ome:master Jan 9, 2020
OMERO.server 5.6.0 (Python 3) automation moved this from Reviewer approved to Done Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manics manics manics left review comments

@joshmoore joshmoore joshmoore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
OMERO.server 5.6.0 (Python 3)
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@will-moore @manics @joshmoore