-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script upload #126
Script upload #126
Conversation
38d4fdb
to
41ce293
Compare
omeroweb/webclient/templates/webclient/scripts/upload_script.html
Outdated
Show resolved
Hide resolved
Yeah, there are relevant |
Upload the script via the UI under
This is correct. This is the new content of the script |
Having feedback during the upload will be great. a wheel spinning or such like |
omeroweb/webclient/templates/webclient/scripts/upload_script.html
Outdated
Show resolved
Hide resolved
Tested the "replace script" option. This works too |
@jburel Improved the UI when uploading. Show spinner and disable form inputs. |
That's great, that's what people were asking for at the Edinburgh workshop too. |
We will probably need to offer the ability to move scripts around |
The text field where the location of the folder is added to is not disabled |
|
Cancelling during the upload does not actually cancel it so this is misleading |
Rename the button to |
|
I tried to upload an invalid file (pdf). This was correctly not allowed. An error message pops up |
Restriction is now in place |
Tested with light-admin with upload script on: works fine |
This PR allows webclient to upload official scripts using a UI similar to Insight's.
To test: