Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting range_size from kwargs negates the limit URL parameter #268

Merged
merged 2 commits into from
Mar 8, 2021

Conversation

kkoz
Copy link
Contributor

@kkoz kkoz commented Mar 3, 2021

Bug fix for #243

@will-moore
Copy link
Member

Hi @kkoz, can you explain what bug is fixed by this and how to test? Thanks

@kkoz
Copy link
Contributor Author

kkoz commented Mar 3, 2021

@will-moore To test, simply query a table with the limit URL parameter set to several different things less than the total number of rows, e.g. http://localhost/webgateway/table/3164/query/?query=*&limit=10. In the current code it will have no effect. With the fix it should limit the number of rows returned.

@jburel
Copy link
Member

jburel commented Mar 8, 2021

@will-moore did you have a chance to test this PR? so we can potentially include in the coming release

@will-moore
Copy link
Member

Working for me on merge-ci (and bug confirmed locally).
Code looks good.
Good to merge 👍

@jburel
Copy link
Member

jburel commented Mar 8, 2021

Thanks @will-moore
Could you add an entry in the changelog?

will-moore added a commit to will-moore/omero-web that referenced this pull request Mar 8, 2021
@will-moore
Copy link
Member

Done

@jburel
Copy link
Member

jburel commented Mar 8, 2021

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants