Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle show object in invalid group #276

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

will-moore
Copy link
Member

Fixes #236

To test:

  • Remove a user from a group where they have some data e.g. a Project (remember it's ID)
  • Log them out, then log them in again, and try to load the project: /webclient/?show=project-1
  • The webclient should load showing their default group (but not finding any Project) - instead of recursively re-loading the page.

@pwalczysko
Copy link
Member

I have the behaviour repeated now without this PR on https://merge-ci.openmicroscopy.org/web/webclient/?show=project-33957, login as import_test_user.

Will check when this PR is in the build.

@pwalczysko
Copy link
Member

this works on merge-ci now as expected. Logging in and out as different users, going via Search or just clicking on the link had the expected effect of landing in the default group of the user in question. No bliniking, the public user could be navigated too, and the login button worked also for other users.

Ready to merge fmpov

@jburel jburel merged commit 9017381 into ome:master Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: webclient gets into endless loop because of group context
3 participants