Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi-select click well images #296

Merged
merged 1 commit into from
Jun 22, 2021

Conversation

will-moore
Copy link
Member

As reported at https://forum.image.sc/t/screens-data-cant-be-displayed-in-omero-figure/40321/5
the multi-select click doesn't work on non-Mac OS machines.

To test:

  • On various OS (Mac, Windows, Linux), should be able to use the appropriate multi-select key with click to toggle selection of Wells of a Plate, and also for individual Images within Wells (at the bottom panel of HCS layout).

@imagesc-bot
Copy link

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/screens-data-cant-be-displayed-in-omero-figure/40321/6

@will-moore will-moore changed the title OME.handleClickSelection() handles multi_key for all OS multi-select click well images Jun 14, 2021
@pwalczysko
Copy link
Member

Not sure we will be able to test this on Windows.
The testing on VB Win10 is not possible as the shortcuts do not work inside the Virtual Box. The Win7 laptop I have is not possible to log in to anymore.

@pwalczysko
Copy link
Member

Works as expected on Mac and Linux but the Windows testing is out of my reach I am afraid.

@pwalczysko
Copy link
Member

Managed to log in on the Windonws laptop and perform the test. Works as expected on Windows too.

Ready to merge fmpov.

@jburel
Copy link
Member

jburel commented Jun 22, 2021

The same logic has been put in place for map annotation and centre plugin
i.e. OME.multi_key() + "Key"

@jburel jburel merged commit b25ce9e into ome:master Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants