Add omero.web config option to set custom favicon #311
Conversation
| @@ -118,7 +118,7 @@ def redirect_urlpatterns(): | |||
| urlpatterns += [ | |||
| url( | |||
| r"^favicon\.ico$", | |||
| lambda request: redirect("%swebgateway/img/ome.ico" % settings.STATIC_URL), | |||
| lambda request: redirect("%s%s" % (settings.STATIC_URL, settings.FAVICON_URL)), | |||
There was a problem hiding this comment.
Would an absolute FAVICON_URL ever be in scope?
There was a problem hiding this comment.
That would require additional nginx/webserver config if you want to do it yourself right?
There was a problem hiding this comment.
@joshmoore You mean something equivalent to the top_links logic where we handle local vv absolute links:
try:
link["link"] = reverse(link_id)
except NoReverseMatch:
# assume we've been passed a url
link["link"] = link_id
I guess for favicon_url you could test url.startswith("http") or something like that?
omeroweb/settings.py
Outdated
| "omero.web.favicon_url": [ | ||
| "FAVICON_URL", | ||
| '"webgateway/img/ome.ico"', | ||
| json.loads, |
There was a problem hiding this comment.
Should this not just be str? Is there a reason for this to be JSON encoded?
There was a problem hiding this comment.
You need to loose the quotes in your example in the PR description and the default now I believe.
|
This works fine for me testing locally and code looks good. 👍 |
This PR introduces a config option to overwrite
webgateway/img/ome.icowith a custom icon.Favicon can be overwritten by setting
favicon_urloption with:The URL to the favicon needs to be specified relative to the Django's static directory.