Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add whitenoise as a dependency #397

Merged
merged 1 commit into from
Nov 2, 2022
Merged

add whitenoise as a dependency #397

merged 1 commit into from
Nov 2, 2022

Conversation

jburel
Copy link
Member

@jburel jburel commented Sep 7, 2022

See ome/omero-documentation#2270 for background discussion
If the proposed change is merged. The installation documentation will need to be adjusted

@will-moore
Copy link
Member

Just adding whitenoise to an existing omero-web dev environment... It is small and doesn't include any other depenencies, so I'm happy to add it as a dependency.

$ pip install whitenoise
Collecting whitenoise
  Downloading whitenoise-6.2.0-py3-none-any.whl (19 kB)
Installing collected packages: whitenoise
Successfully installed whitenoise-6.2.0

Copy link
Member

@will-moore will-moore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jburel
Copy link
Member Author

jburel commented Sep 7, 2022

see ome/omeroweb-install#85

@joshmoore
Copy link
Member

👍 Thanks, @jburel. Guess the only questions are if there are any other dangling deps like this and if we know why it had such a special status.

@jburel
Copy link
Member Author

jburel commented Sep 9, 2022

The only one that could be included is django-redis==5.0.0

@joshmoore
Copy link
Member

That seems more clearly like an add-on.

@jburel
Copy link
Member Author

jburel commented Sep 9, 2022

That seems more clearly like an add-on.

agree

@jburel jburel merged commit f592b21 into ome:master Nov 2, 2022
@jburel
Copy link
Member Author

jburel commented Nov 4, 2022

Suggesting to push a tag: 5.16.0 since we have a dependency injection
Since we avoid to update the upgrade installation instruction i.e. ome/omero-documentation#2270
Any objections?

@will-moore
Copy link
Member

👍

@sbesson
Copy link
Member

sbesson commented Nov 4, 2022

As per the dependency argument, would #415 also be a candidate for 5.16.0?

@jburel
Copy link
Member Author

jburel commented Nov 4, 2022

It makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants