Deprecate omeroweb.custom_forms.NonASCIIForm #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original intent of the NonASCIIForm was to support Unicode strings by overriding the CharField validation. Unicode is now natively supported by the Python/Django stack. This commit proposes to drop our intermediate custom class in favor of upstream django.forms.Form. This should incidentally reduce the maintenance burden when upgrading between Django major versions.
will-moore
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #468
The original intent of the NonASCIIForm was to support Unicode strings by overriding the CharField validation. Unicode is now natively supported by the Python/Django stack. This commit proposes to drop our intermediate custom class in favor of upstream
django.forms.Form. This should incidentally reduce the maintenance burden when upgrading between Django major versions.Testing:
All places using the legacy base form should be reviewed with this change using both ASCII strings and Unicode strings as inputs. Below is a list of endpoints to review
/webclient/login//webadmin/forgottenpassword//webadmin/myaccount//webadmin/experimenter/new/webadmin/experimenter/edit/{id}(includingChange User's Password)/webadmin/group/edit/{id}/webclient/search/