Fix webclient figure scripts dialog #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This script is not supported in the views.py code and simply returns an error
|
Split figure works on merge-ci. 👍 |
manics
reviewed
Nov 21, 2019
omeroweb/webclient/views.py
Outdated
| @@ -4396,7 +4396,8 @@ def run_script(request, conn, sId, inputMap, scriptName='Script'): | |||
| request.session.modified = True | |||
| except Exception as x: | |||
| jobId = str(time()) # E.g. 1312803670.6076391 | |||
| if x.message and x.message.startswith("No processor available"): | |||
| if hasattr(x, 'message') and x.message and \ | |||
There was a problem hiding this comment.
Is the lack of message due to the change from Py2→Py3 Exceptions (might need something like x.args[0] instead of x.message?)
|
Functionally this works on py3-ci, but check the exception handling |
|
Ah, good point - will check exception handling... |
|
Merging based on #71 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71
Fixes dialogs for Thumbnail Figure and Split-View Figure.