download images as zip + CSS fixes #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This still results in a zip file of 0 size
will-moore
changed the title
will-moore
changed the title
|
Fails on today's py3-ci with |
|
Apologies: I think the build failure this morning meant that this wasn't deployed. Seems to be working now. I'll list again tomorrow... |
mtbc
approved these changes
Dec 2, 2019
|
(Worth noting the UI fixes in the CSS.) |
Added to the description as a reminder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this is working it will fix #72
See test at ome/openmicroscopy#6179
To test:
Test was previously failing at https://py3-ci.openmicroscopy.org/jenkins/job/OMERO-test-integration/lastCompletedBuild/testReport/OmeroWeb.test.integration.test_download/TestDownloadAsPng/test_download_images_as_zip/
but should now be passing