Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle negative numbers in UIUtilities.findDecimal() (Fixes #11484) (rebased onto develop) #1580

Merged
merged 4 commits into from
Oct 10, 2013

Conversation

jburel
Copy link
Member

@jburel jburel commented Oct 3, 2013

This is the same as gh-1571 but rebased onto develop.


Ticket for reference with more overarching explanation:

Test case to be run as follows:

./build.py clean build
...
cd components/insight/build/
ant -Dtest.suite.include=**/shoola/util/ui/TestUIUtilities.java test
...

Both unit tests should pass.

@jburel
Copy link
Member Author

jburel commented Oct 3, 2013

--rebased-from #1571

@mtbc
Copy link
Member

mtbc commented Oct 10, 2013

    [junit] Testsuite: org.openmicroscopy.shoola.util.ui.TestUIUtilities
    [junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 0.254 sec

Good to merge.

By the way, that's an interesting way to run a test. I wonder if it deserves a mention in the documentation on developers/testing.txt or developers/Insight/Contributing.txt.

@joshmoore
Copy link
Member

@mtbc: agreed. This is a glimpse into how the insight build itself works. Time to enable a few tests by default from insight/build.xml? /cc @bpindelski.

joshmoore added a commit that referenced this pull request Oct 10, 2013
Handle negative numbers in UIUtilities.findDecimal() (Fixes #11484) (rebased onto develop)
@joshmoore joshmoore merged commit 4625d1b into ome:develop Oct 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants