Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #11465: add validation checks for admin service (rebased) #1595

Merged
merged 18 commits into from
Oct 8, 2013
Merged

fix #11465: add validation checks for admin service (rebased) #1595

merged 18 commits into from
Oct 8, 2013

Commits on Oct 7, 2013

  1. remove svn revision notes

    @mtbc
    mtbc committed Oct 7, 2013
    Configuration menu
    Copy the full SHA
    df1a6db View commit details
    Browse the repository at this point in the history

  2. add guest user to Roles object

    @mtbc
    mtbc committed Oct 7, 2013
    Configuration menu
    Copy the full SHA
    01fa45b View commit details
    Browse the repository at this point in the history

  3. add convenience predicates for boolean role properties

    @mtbc
    mtbc committed Oct 7, 2013
    Configuration menu
    Copy the full SHA
    5a27bc8 View commit details
    Browse the repository at this point in the history

  4. fix #11465: add further admin action validation 

    Conflicts:
	components/server/src/ome/logic/AdminImpl.java
    @mtbc
    mtbc committed Oct 7, 2013
    Configuration menu
    Copy the full SHA
    958b56c View commit details
    Browse the repository at this point in the history

  5. minor code cleanup to reduce compiler warnings 

    Conflicts:
	components/server/src/ome/logic/AdminImpl.java
    @mtbc
    mtbc committed Oct 7, 2013
    Configuration menu
    Copy the full SHA
    0f999f3 View commit details
    Browse the repository at this point in the history

  6. add Javadoc documenting #11465 changes

    @mtbc
    mtbc committed Oct 7, 2013
    Configuration menu
    Copy the full SHA
    dd57c1c View commit details
    Browse the repository at this point in the history

  7. reword admin user text

    @mtbc
    mtbc committed Oct 7, 2013
    Configuration menu
    Copy the full SHA
    60937b5 View commit details
    Browse the repository at this point in the history

  8. do not allow users to be removed from all groups

    @mtbc
    mtbc committed Oct 7, 2013
    Configuration menu
    Copy the full SHA
    ad4ec6e View commit details
    Browse the repository at this point in the history

  9. remove unused import

    @mtbc
    mtbc committed Oct 7, 2013
    Configuration menu
    Copy the full SHA
    32aee68 View commit details
    Browse the repository at this point in the history

  10. add integration tests for #11465 validation checks

    @mtbc
    mtbc committed Oct 7, 2013
    Configuration menu
    Copy the full SHA
    9737711 View commit details
    Browse the repository at this point in the history

  11. remove uselessly blank lines

    @mtbc
    mtbc committed Oct 7, 2013
    Configuration menu
    Copy the full SHA
    8bd00e8 View commit details
    Browse the repository at this point in the history

  12. make admin service test user creation more succinct 

    Conflicts:
	components/tools/OmeroJava/test/integration/AdminServiceTest.java
    @mtbc
    mtbc committed Oct 7, 2013
    Configuration menu
    Copy the full SHA
    bfe6167 View commit details
    Browse the repository at this point in the history

  13. adjust remove groups validation

    @mtbc
    mtbc committed Oct 7, 2013
    Configuration menu
    Copy the full SHA
    bfabc5a View commit details
    Browse the repository at this point in the history

  14. add fail's and adjust whitespace

    @mtbc
    mtbc committed Oct 7, 2013
    Configuration menu
    Copy the full SHA
    8bfd1d0 View commit details
    Browse the repository at this point in the history

  15. removing decorator from failing test as issue in #11465 was resolved 

    upgrading test in order to catch an exception
    @atarkowska @mtbc
    atarkowska authored and mtbc committed Oct 7, 2013
    Configuration menu
    Copy the full SHA
    7867de8 View commit details
    Browse the repository at this point in the history

  16. add extra fields to Roles

    @mtbc
    mtbc committed Oct 7, 2013
    Configuration menu
    Copy the full SHA
    8815a40 View commit details
    Browse the repository at this point in the history

  17. utilize new Roles fields

    @mtbc
    mtbc committed Oct 7, 2013
    Configuration menu
    Copy the full SHA
    184fb75 View commit details
    Browse the repository at this point in the history

  18. create test users with non-user default group

    @mtbc
    mtbc committed Oct 7, 2013
    Configuration menu
    Copy the full SHA
    311a187 View commit details
    Browse the repository at this point in the history