-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade ICE jars to version 3.5.1 #1633
Conversation
@rleigh-dundee: Did you evaluate the testing time and workflow for that PR? so we can carefully plan the review of the PR. |
It's simply replacing the ice 3.5.0 jars with ice 3.5.1 jars; they should be comletely compatible and so there should be no changes as a result. Testing will need to cover the client and the server, so we will need to deploy the server on gretzky. We can do this quite easily e.g. using tomorrow's ice35 merge build, and test the corresponding clients at the same time. |
@rleigh-dundee: I realise that but the "it should be compatible" requires to retest the compatibility with all the servers version. 3.3, 3.4 and 3.5 and same for the clients. This will have to be done in stage so we do not use all our resources. |
These jars break with javadoc from java 1.7 due to containing source code as well as classes. The reasons why this occurs are not clear, but excluding them works around the immediate breaking of the build. The breakage occurs with the Ice 3.5.1 jars, but given that the 3.5.0 (and other) jars also contain essentially similar content, it's not clear what the trigger for the breakage is. It could be a javadoc bug.
The jenkins build is now green (http://hudson.openmicroscopy.org.uk/job/OMERO-merge-develop-ice35/) so should be OK to merge. |
Thanks, @rleigh-dundee ! |
Upgrade ICE jars to version 3.5.1
--rebased-to #1805 |
No description provided.