Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Weird behaviour after switching users (rebased onto dev_4_4) #2200

Merged
merged 2 commits into from
Apr 1, 2014

Conversation

dominikl
Copy link
Member

This is the same as gh-2189 but rebased onto dev_4_4.


After switching users new service adapter instances were created but never passed on to the registry, so subsequent calls to the server picked up old service adapter instances, with the old OMEROGateway which still used the session created by the previous user.

Fix for: https://trac.openmicroscopy.org.uk/ome/ticket/12055
Should also fix other issues due to switching users

To Test: Follow the scenario mentioned in the ticket above;

After switching user new service adapater instances were created but never
passed on to the registry.
@dominikl
Copy link
Member Author

--rebased-from #2189

@dominikl dominikl restored the rebased/dev_4_4/projects_disappear branch March 24, 2014 14:24
@sbesson
Copy link
Member

sbesson commented Mar 25, 2014

@jburel @pwalczysko: assuming you are still potentially needing howe for you training tour, should we postpone the review of this PR to your return?

@jburel
Copy link
Member

jburel commented Mar 25, 2014

@sbesson: @pwalczysko might need howe today we should then be okay.
The PR can be added tomorrow

@sbesson
Copy link
Member

sbesson commented Mar 25, 2014

Understood. @pwalczysko: can you ping me if you think you are done with the server and I will manually retrigger the 4.4 merge jobs.

@dominikl
Copy link
Member Author

@jburel @sbesson

As Gus found another issue with switching users: #2199
Should I try to fix this within this PR, and put this PR as well as #2199 and #2189 on hold? Though I would suggest to go for another separate PR.

@jburel
Copy link
Member

jburel commented Mar 26, 2014

@dominikl: I will first fix on dev_5_0. so we can first access the number of changes. The problem noticed by @gusferguson is different. It is related to the import As option so it should be done in another PR.

@jburel
Copy link
Member

jburel commented Mar 26, 2014

@sbesson: we do not need howe anymore so job can be triggered again

@sbesson
Copy link
Member

sbesson commented Mar 26, 2014

@gusferguson
Copy link

@dominikl @jburel
Tested using OMERO.insight-4.4.10-20-12e1083-ice33-b486-win on Windows 8 user-6, user-3 user-9 read-annotate-1

Logged in as user-6 imported as self, user-3 and user-9
Switch user to user-3 imported as self
Switch user to user-6 imported as self, user-3 and user-9
Switch user to user-9 imported as self
Quit
Logged in as user-9 imported as self
Switch user to user-6 imported as self, user-3 and user-9
Switch user to user-3 imported as self
Switch user to user-6 imported as self, user-3 and user-9
Switch user to user-9 imported as self

In all cases created projects and datasets at import.
In all cases correct ownership of containers and images was found.

Behaves as expected.
Good to merge.

joshmoore added a commit that referenced this pull request Apr 1, 2014
…pear

Bugfix: Weird behaviour after switching users (rebased onto dev_4_4)
@joshmoore joshmoore merged commit 910ad54 into ome:dev_4_4 Apr 1, 2014
@dominikl dominikl deleted the rebased/dev_4_4/projects_disappear branch May 19, 2014 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants