All other remaining webstart code-signing changes (rebased onto develop) #2321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're going to be code-signing in a separate process, so this prevents jars being double-signed, once with the self-signed cert and once with a proper one. The webstart-sign target is still there, so you can use `./build.py webstart-sign release-webstart`.
Automatically run this script with the existing self-signed certificate as part of the standard docs/hudson/OMERO.sh build
|
--rebased-from #2193 |
This is so that ./build.py clean will remove any logs or temporary directories
Removed release-webstart build target Add release-webstart-unsigned target (doesn't sign jars) Add release-webstart-signed target (self signs jars using omero_insight_sign.py). release-all runs release-webstart-unsigned so the final artifacts will be unsigned. webstart-sign target has been changed to use the omero_insight_sign.py script instead of the old jarsigner ant calls
This means update-version won't sign any updated webstart jars. (Actually it didn't anyway since it was removed in commit ff99355, this just cleans up build.xml)
Return code depends on Java version
Just in case any pedants are reading
This was referenced Apr 16, 2014
manics
changed the title
|
All looks good here. Running |
|
Merging. May the force be with us. |
joshmoore
added a commit
that referenced
this pull request
Apr 17, 2014
…designing_tweaks All other remaining webstart code-signing changes (rebased onto develop)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a combination of gh-2193 gh-2241 gh-2271 rebased onto develop.
i.e. all of the remaioning webstart code-signing PRs