Extra annotations #2412
Merged
Extra annotations #2412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
--depends-on ome/bioformats#1054 |
Closed
|
Can we get rid of the whitespace changes? |
|
The indenting of the file was all over the place and a mix of tabs and spaces. I found it hard to follow. |
There were a variety of styles of "TODO" markers for methods that were not implemented: "TODO not in Model", "unsupported", etc. This converts all of them to use helper methods `protected ignoreX()` which log at various levels. It should be fairly easy now to do a "Open call hierarchy" style search and see which methods fall into which category. Also, **with this commit, the remaining TODOs in the file are valid!**
Unlike the methods which now log with `ignoreY()`, these methods seem to have been improperly implemented or left improperly unimplemented. These need careful review.
General cleanup of TODO markers and addition of logging
The sections of code removed with the removal of WellSample and Pixels from the annotatable objects might be useful as a template of what needs added for each of the new annotatable objects.
Conflicts: components/blitz/src/ome/formats/OMEROMetadataStoreClient.java
|
Travis failure. |
|
A valid compile fail, I believe. @qidane? |
|
Breaking Build passing - is this ok to remove breaking (along with ome/bioformats#1054). |
|
As ome/bioformats#1054 (comment), no label so you can decide post full-repo run. |
|
Travis failed with |
The option is not implemented server side. No need to keep the tests.
Extra annotations Changes to complete the tests and correct my spec.xml entries
|
@qidane: Travis is green!!! |
|
removed breaking tag |
|
Note: from discussion this afternoon, if the full-repo is green, this and it's BF partner will be merged. |
|
Merging to allow the submodules job to be run |
|
--no-rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding extra annotation points to the model