Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OmeroCpp: Disable remaining integration search test #3128

Merged
merged 1 commit into from Nov 3, 2014
Merged

OmeroCpp: Disable remaining integration search test #3128

merged 1 commit into from Nov 3, 2014

Conversation

ghost
Copy link

@ghost ghost commented Oct 22, 2014

This should remove the intermittent integration test failure we're seeing.

@ghost
Copy link
Author

ghost commented Oct 23, 2014

--no-rebase

@bpindelski
Copy link

https://ci.openmicroscopy.org/view/Failing/job/OMERO-5.1-merge-cpp-cmake/ doesn't run the disabled test anymore, but snipe failed again with a test timeout. In general, this looks OK to merge.

@ghost
Copy link
Author

ghost commented Oct 23, 2014

I think the timeouts still need work, but I'm not sure about what we're doing wrong here to fix it.

@bpindelski
Copy link

I agree about the timeout issue being annoying. The Java tests suffer from the same thing. On the Java side I tried using a back-off time value for the command timeout. That value was calculated before each test class was run and should have been an indicator of the "latency" of the node (i.e. higher value would configure the command object to wait longer for the operation to finish on the server). I'd say it works in 50% of the cases and we still get timeouts on the Java front. There is hope that @mtbc's work on graph traversal will speed up some of the command operations (delete, chgrp etc.), so until then I don't have any other ideas.

@mtbc
Copy link
Member

mtbc commented Oct 23, 2014

I certainly hope it'll help, especially in the cases where there are many model objects involved that individually may or may not be orphans (like a dataset full of images). However, we may have to solve separate issues like http://trac.openmicroscopy.org.uk/ome/ticket/11084 before we can get these operations anywhere near as fast as they should be. (I'll also look for opportunity for speedups once #3000 is in.)

@joshmoore
Copy link
Member

Jotted down under https://trello.com/c/Gsc76NVp/312-disabled-tests ; merging.

joshmoore added a commit that referenced this pull request Nov 3, 2014
OmeroCpp: Disable remaining integration search test
@joshmoore joshmoore merged commit 7bc23ec into ome:develop Nov 3, 2014
@ghost ghost deleted the cpp-test-disable2 branch November 3, 2014 20:21
@sbesson sbesson added this to the 5.1.0-m2 milestone Nov 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants