No stats ui #3596
Merged
No stats ui #3596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Discussed with @pwalczysko and @gusferguson: we will keep the button active to keep both clients in synch.Min/max action will behave like Full range. one more commit to come |
This matches the behaviour in web.
|
Imported a bunch of dv images, once with "--no_stats_info" and once without. Channel sliders were displayed correctly, min/max and fullrange actions worked like expected (min/max behaves like fullrange in the case of "--no_stats_info" import). Good to merge. |
|
--no-rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some UI issues when no stats info for the image
To test
Note that Web still has the min/max enabled, if click on min/max, it defaults to Full range.
is it the behaviour we want? @gusferguson @will-moore @pwalczysko