Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log null statsInfo at 'debug' instead of 'error' #3626

Merged
merged 2 commits into from
Mar 23, 2015

Conversation

will-moore
Copy link
Member

Since it's no longer an error to have no stats info (see #3580) we should log this merely at 'debug' level instead of 'error'.

To test:

  • Import image with no stats
  • Open in web - observe Web log for lack of errors.

--no-rebase.

@jburel jburel added the develop label Mar 17, 2015
@sbesson
Copy link
Member

sbesson commented Mar 18, 2015

Setting omero.web.debug to True, I can confirm the StatsInfo message is displayed at DEBUG level instead of ERROR level with this PR included.
With regard to the impact of this change, I would consider this logging message important enough to promote it to the INFO level instead. With the exposition of --skip parameters, users may run into more of these issues and we may want to have this information logged by default in production instances. /cc @jburel

@jburel
Copy link
Member

jburel commented Mar 18, 2015

probably better to have it at INFO level as @sbesson suggested. not really a DEBUG

@sbesson
Copy link
Member

sbesson commented Mar 23, 2015

2015-03-23 08:32:24,506  INFO [                           omero.gateway] (proc.30074) getWindowMin:6629 getStatsInfo() is null. See #9695
2015-03-23 08:32:24,507  INFO [                           omero.gateway] (proc.30074) getWindowMax:6650 getStatsInfo() is null. See #9695

Thanks

sbesson added a commit that referenced this pull request Mar 23, 2015
Log null statsInfo at 'debug' instead of 'error'
@sbesson sbesson merged commit dcc627f into ome:develop Mar 23, 2015
@sbesson sbesson added this to the 5.1.0 milestone Apr 2, 2015
@will-moore will-moore deleted the getStatsInfo_blitz_logging branch May 25, 2015 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants