-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable graph and intensity pane for bigimages without stats #3631
Conversation
b09be83
to
22b1459
Compare
Although the PR IS included, the crash still happens on user-4 image ID 25557 |
22b1459
to
e420070
Compare
Sorry @pwalczysko , looks like I pushed a wrong commit before. Now it's the right one and it should work (in the next merge build). |
To do this "right", do we need another method like |
I don't really know, what to do on the server side, but I guess we shouldn't/can't do anything about that for 5.1.0-m5. The |
Tested for
All works as expected. |
Thanks for the explanation, @dominikl. If you guys do need another boolean method to differentiate, say the word. |
Disable graph and intensity pane for bigimages without stats
@dominikl: for float we should not use |
Ah, I didn't know that there is an |
Workaround for Ticket 12790
Problem: Graph and Intensity view pane should actually be disabled for big images, but float images aren't recognized as big images (PixelService.requiresPixelPyramid() always returns false for float images -> which on the client side means, it's not a big image). And with #3525 float big images don't have a statsinfo anymore, i. e. global min/max of channels can't be determined, which raised the exception in the ticket above, because this is needed for the graph and intensity view pane. This PR disables the graph and intensity view pane in these cases.
It's more a workaround, because the underlining cause (float images aren't recognized as 'big images') is not tackled here.
@jburel Your thoughts, use this workaround or add some kind of isBigImage() method to Pixelservice, to determine if an image exceeds max plane size, regardless of pixel pyramid is required or not?
Actually, further thinking about it, with #3580 it's possible to also import small images without stats generation with
--no_stats_info
(even this doesn't make sense, I guess), which also would raise the exception in Ticket 12790, so regardless of the big image problem, this PR would make sense to merge anyway.Test:
Sample image for testing: mrc/AMI-public-data/GroEL/05may19a_00013gr_00008sq_00002hl_00002ef.mrc in team/will/float-data.zip
--no-rebase