Import improvements #4239
Merged
Import improvements #4239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now with `--exclude=clientpath` its possible to use the client-side absolute filepath to determine whether or not an import has already taken place. This exclusion does *not* check for the checksum of the target file, but rather assumes that the client-side path is unique enough to prevent false positives.
The check of List.contains(LSID) was extremely time expensive. This code could use a further refactoring but that will mean changing public methods. Instead, here we simply maintain a map of checks which can be used to speed up the parsing.
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These 2 commits were previously a part of gh-4125 and were extensively tested for the SiB demo.