Remove command

[jburel]

Use nio package to create hard link and symlink

Test the various in-place import options on several OS.

cc @joshmoore @mtbc @pwalczysko

[joshmoore]

The error code handling from exec will need to be resurrected as exception handling. Specifically the error messages were requested so that users could figure out what was going on.

Also, since createProcessBuilder is protected, this would count as a breaking change since it would no longer do anything for subclasses which implement the createProcessBuilder method. Options I can think of:

• keep createProcessBuilder but return an implementation which calls the native Java method
• leave AbstractExecFileTransferas it is, and implement add new classes (Hardlink2FileTransfer extends AbstractFileTransfer` (that may require moving some of the methods from AEFT up to AFT)

[jburel]

@joshmoore: thanks I was not sure about the plan for error handling since the method already returns IOException (not handled)

I will see what I can do. I might add new classes

[jburel]

I have introduced new classes. I opted for a new AbstractExecFileTransfer2.
The simplest thing might be to mark some classes deprecated this round and use 5.3 for an update.
1.6 support was dropped a while back and those classes never got cleaned up.

[joshmoore]

Excluding for the moment: https://ci.openmicroscopy.org/view/Failing/job/OMERO-DEV-merge-integration-python/lastCompletedBuild/testReport/OmeroPy.test.integration.clitest.test_import/TestImport/testSymlinkImport/ et al.

[jburel]

Sorry I did not have a chance to run the tests. I will try to do that this pm

[jburel]

Another example of testing headache (plenty with Ice 3.6)
run locally
test/integration/clitest/test_import.py::TestImport::testSymlinkImport PASSED

@sbesson is the workspace cleaned daily? since the failure is due to a "FileAlreadyExistsException"
and I cannot reproduce it locally

[jburel]

@joshmoore @sbesson:
run the tests on breaking with this PR included
no problem see https://ci.openmicroscopy.org/view/OMERO-DEV/job/OMERO-DEV-breaking-integration-python/491/

[sbesson]

@jburel: interestingly this PR was not picked in the merge job - see https://ci.openmicroscopy.org/view/DEV/job/OMERO-DEV-breaking-push/623/ and snoopycrimecop@2951b97

[jburel]

It did not pick when I removed the exclude label
I am going to run it again

[jburel]

Few errors on breaking. I will investigate when I get back since the Symlink test passes locally
Same problem with the fs test currently failing.

[jburel]

Tested locally symlink creation with both Java 1.7 and 1.8 no problem noticed

[jburel]

The difference between local and server is the java version installed. I will run some tests on docker now that we have the various parameters in place.
Closing this PR for now.