-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Right panel annotation tabs2 #4660
Conversation
Tested with cowfish user-3 read-only-1 Behaves as expected. |
This is probably casing failing test at https://ci.openmicroscopy.org/view/Failing/job/OMERO-DEV-merge-integration-Python27/215/testReport/OmeroWeb.test.integration.test_csrf/TestCsrf/test_add_and_remove_comment/ Will check... |
To test last commit, add Comment to single object and multiple (batch) objects. |
Tested with https://cowfish.openmicroscopy.org/webmerge/webclient/ user-3 read-only-1 Comments behave as expected for both single and multiple objects. |
These are not used now
Last commit above removes unused load_public() and containers_icon.html. To test, check functionality of the Public tab. Create and browse shares. |
Tested using https://cowfish.openmicroscopy.org/webmerge/webclient/ user-3 and user-2 Share functionality behaves as expected. |
The current loading of shares and images, used by webclient since 5.2.0 is covered by test_tree.py
Probably need to be relisted? |
Tested with https://cowfish.openmicroscopy.org/webmerge/webclient/ user-3 Behaves as expected for P/D/I S/R/W. Good to merge. |
Cf. last commit, this needs to be synchronised w/ current work done by @aleksandra-tarkowska @pwalczysko, and @sbesson on "share tests" before removing the tests. |
The tests were removed because the code they test was removed because it is no-longer used. |
discussed privately with @will-moore |
This is a follow-up to #4579 with a refactor of tag loading and a lot of other code cleanup / removal.
Also added some web tests for annotate_tags.
To test: