Codomain per channel rnd

[jburel]

What this PR does

Re-activate the codomain map context. This was initially per rendering. Part I of the work
This is now per channel (part II). see #4793

Existing methods add/remove/update have been deprecated. Note that they have never been used.

New methods have been added to add/remove/retrieve the codomain contexts associated to a channel
No update method.
Only the ReverseIntensityMapContext has been added.

Testing this PR

Integration test has been updated

Related reading

https://trello.com/c/9iAe3Sg9/95-lut-support

cc @will-moore @dominikl

[joshmoore]

Javadoc issue? https://ci.openmicroscopy.org/job/OMERO-DEV-merge-build/421/warnings40Result/module.1453757448/

[jburel]

I was wrestling with travis this am, good that it is now picked up ;-)

[jburel]

@will-moore @dominikl: The last commit should fix #4823 (comment)

[jburel]

@dominikl: I noticed the test failure i.e. https://ci.openmicroscopy.org/view/Failing/job/OMERO-DEV-merge-integration-java/372/testngreports/integration/RenderingEngineTest/testReverseIntensityWithLut/ I will fix it.

[jburel]

The test passes locally, another error probably due to the directory re-organisation.

[jburel]

https://ci.openmicroscopy.org/job/OMERO-DEV-merge-integration-java/373/ is back green

[dominikl]

Looks good, thumbnails working again, so are the integration tests, can't see any other problems 👍

[will-moore]

Everything seems to be working on #4839 so I think this is good to merge.

[will-moore]

As reported by @pwalczysko #4839 (comment)
As a non-owner of an image where MY rendering settings are saved WITH Reverse Codomain, resetting to owner's rendering settings doesn't remove Reverse Codomain (owner doesn't have Reverse intensity). Other settings from the owner are applied.

In [3]: rss = conn.getRenderingSettingsService()
In [4]: rv = rss.resetDefaultsByOwnerInSet('Image', [16783])

[will-moore]

Also, as reported by @pwalczysko, #4839 (comment)
applySettingsToSet() is working for applying Reverse Codomain to the set, but doesn't work for removing the Reverse Codomain from the set.

[jburel]

@will-moore @pwalczysko: The problems reported in #4823 (comment) and #4823 (comment) should now be fixed

[pwalczysko]

The problems #4823 (comment) seem to be fixed in the backend as verified today using Insight (web PR is not in the build today).

[jburel]

https://ci.openmicroscopy.org/job/OMERO-DEV-merge-integration-java/379/ is green

[pwalczysko]

Reviewing the Rnd workflows again in Insight, I have come accross a bug.

• open an image in Full Viewer (one of the 56-lei) and tick (in Full Viewer) the checkbox "Reverse intensity" in one channel (do not Save, do not close the Full Viewer)
• go to the containing dataset in the tree, right-click and Paste and Save
• observe that all works as expected (all thumbs in central change accordingly)
• now, still on the dataset, right-click and Set Imported and Save
• observe that all works as expected except the image whose Full Viewer is open -> this image's thumbnail in central pane remains unchaged by the Set Imported and Save, all the others change as expected.

@dominikl is telling me this is not to do with this PR but with some older PR of his which is in merge.
Note that the bug CANNOT be repeated on eel latest.

[pwalczysko]

Other than #4823 (comment) all works as expected.

[dominikl]

Pretty sure the bug is related to #4862 (comment)

[jburel]

Thanks @pwalczysko for report, so if I understand correctly no work required on this PR but a problem to fix in insight

[pwalczysko]

This bug #4823 (comment) is gone as of today.

[jburel]

Does it mean that this PR is ready from your pov?

[pwalczysko]

Yes, ready to go, sorry.

[jburel]

merging this refactoring PR, any improvement/addition will be done in follow up PR if need be

Thanks all for review and tests