Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OMERO_Matlab:Fix the casting from *unit8 to int8 #4831

Merged
merged 1 commit into from Sep 24, 2016

Conversation

bramalingam
Copy link
Member

What this PR does

ref:
https://www.openmicroscopy.org/community/viewtopic.php?f=6&t=8117

Testing this PR

  1. Test the Matlab toolbox with the code snippet given in the forum post.
  2. Check if the test-code runs without any errors.

@bramalingam bramalingam changed the title Fix the casting from *unit8 to int8 OMERO_Matlab:Fix the casting from *unit8 to int8 Sep 9, 2016
@jburel jburel added the develop label Sep 9, 2016
@sbesson
Copy link
Member

sbesson commented Sep 9, 2016

I wonder if it would make sense here to take advantage of the minimal example provided by the user in the forum post and extend the WriteData training example to upload a mask created with imread, retrieve it and compare both input and output are equal?

@bramalingam
Copy link
Member Author

bramalingam commented Sep 9, 2016

Yes that makes sense, will add that minimal test to the writeData training example. Although the downloaded version comparison cannot happen as suggested by the user. (unless we want to check the downloads aspect as well in this test)

@jburel
Copy link
Member

jburel commented Sep 9, 2016

This is a candidate PR for 5.2.6. see https://trello.com/c/oWtA5Pod/9-omero-matlab-regression#

@imunro
Copy link
Contributor

imunro commented Sep 12, 2016

PR Looks Good to me. FYI I've been doing some testing locally and it looks as if any string starting with '*' is invalid and therefore Matlab (Silently) uses the default which is uint8. Writing test data to a file it seems as if 0-7F hex are written fine but anything outside this range is written , to the file, as 00. The results will be unpredictable depending on the original data type.

@jburel
Copy link
Member

jburel commented Sep 16, 2016

@bramalingam could you rebase this PR to dev_5_2?

@bramalingam
Copy link
Member Author

--rebased-to #4849

@jburel
Copy link
Member

jburel commented Sep 24, 2016

@jburel jburel merged commit a04b1ee into ome:develop Sep 24, 2016
@jburel jburel added this to the 5.3.0 milestone Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants