-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codomain web #4839
Merged
Merged
Codomain web #4839
Changes from 2 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
32ff94c
Add reverse intensity methods to Blitz Gateway.
will-moore 743dd85
Add reverseMap support to webgateway split_channel_info()
will-moore ff794dc
Move Blitz isReverseIntensity() to channel from image
will-moore 7c3bc03
channelMarshal includes reverseIntensity: boolean
will-moore d3fe66a
Show 'Reverse Intensity' checkbox in colorpicker dialog
will-moore a5ca492
Adding cyan to list of colors in colorpicker
will-moore d768054
Handle 'reverseIntensity' in undo, save, compare channels
will-moore 6b5dd2e
Include 'reverseIntensity' in Blitz image.getAllRenderingDefs()
will-moore 6bb7066
Use no 'r' in rdef string to disable reverse
will-moore 50a077b
Include 'r' for reverseIntensity in copy_image_rdef_json
will-moore 6cfb26b
Update image marshal test to expect 'reverseIntensity' in channels
will-moore bea20b8
Use '-r' flag to turn OFF reverse intensity explicitly
will-moore 614ebc1
Handle -r flag in setQuery()
will-moore e79b5a9
Fix Click user thumbnail rdef removes reverse-intensity
will-moore 5b0479d
Reverse Intensity checkbox doesn't scroll in dialog
will-moore 0a1c0ae
Merge remote-tracking branch 'origin/develop' into codomain_web
will-moore 54689c0
Merge remote-tracking branch 'origin/develop' into codomain_web
will-moore 996a4da
Include reverseIntensity in test copy_paste rdefs
will-moore f616178
Include reverseIntensity in test_all_rendering_defs
will-moore File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@will-moore sorry, I know I'm being a bit knitpicky here but would it be a major problem if we handled that with a split for ':' . Syntactically it seems a tad clearer/cleaner to get a tuple/triple with min:max:optRev.
something like this maybe?