Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getThumbnails_test #5235

Merged
merged 4 commits into from
May 9, 2017
Merged

getThumbnails_test #5235

merged 4 commits into from
May 9, 2017

Conversation

will-moore
Copy link
Member

What this PR does

Adds a test based on testing of #5207

As seen in webclient and reproduced in Python, after 'Save to All' getting thumbnail set WITH
omero.group: -1 fails until we get a thumbnail set WITHOUT omero.group: -1

Test reproduces this but uses with pytest.raises(omero.SecurityViolation): to wrap the failing line.
Should be removed when the bug is fixed.

Testing this PR

  1. Test should be green.

cc @mtbc

@jburel jburel added the develop label Apr 6, 2017
@will-moore
Copy link
Member Author

@aleksandra-tarkowska Fixed test. Should be able to include this now, thanks.

@jburel
Copy link
Member

jburel commented Apr 10, 2017

Removed the exclude flag

@mtbc
Copy link
Member

mtbc commented Apr 12, 2017

... and it's now passing. 👍

@mtbc
Copy link
Member

mtbc commented Apr 20, 2017

Want to try adding an integration test to reproduce issue at #5207 (comment) ?

@will-moore
Copy link
Member Author

@mtbc As far as I can see, getThumbnailSet() was failing after 'save to all' but the test I wrote for that is now passing. I'm not sure how to reproduce the latest failures, except maybe to simply add a large number of images to that same test? But if it's failing because "you can't getThumbnailSet() while thumbnails are being re-created", then we don't have a fix for that, right? So this would likely stay as a failing test which might not be very useful?
Also I could try add a failing test for shares if that would help fix the issue?

@mtbc
Copy link
Member

mtbc commented Apr 28, 2017

Yeah, doesn't sound like it's worth it at this time, does it? Thank you for your thoughts! If there aren't any regressions with shares then I think we're probably good unless IDR depends on them. At least, I'm unlikely in the near future to get to investigating handling in-progress thumbnails!

@jburel jburel merged commit add53b5 into ome:develop May 9, 2017
@jburel jburel added this to the 5.3.2 milestone May 16, 2017
@will-moore will-moore deleted the getThumbnails_test branch February 18, 2019 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants