-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getThumbnails_test #5235
getThumbnails_test #5235
Conversation
@aleksandra-tarkowska Fixed test. Should be able to include this now, thanks. |
Removed the exclude flag |
... and it's now passing. 👍 |
Want to try adding an integration test to reproduce issue at #5207 (comment) ? |
@mtbc As far as I can see, getThumbnailSet() was failing after 'save to all' but the test I wrote for that is now passing. I'm not sure how to reproduce the latest failures, except maybe to simply add a large number of images to that same test? But if it's failing because "you can't getThumbnailSet() while thumbnails are being re-created", then we don't have a fix for that, right? So this would likely stay as a failing test which might not be very useful? |
Yeah, doesn't sound like it's worth it at this time, does it? Thank you for your thoughts! If there aren't any regressions with shares then I think we're probably good unless IDR depends on them. At least, I'm unlikely in the near future to get to investigating handling in-progress thumbnails! |
What this PR does
Adds a test based on testing of #5207
As seen in webclient and reproduced in Python, after 'Save to All' getting thumbnail set WITH
omero.group: -1
fails until we get a thumbnail set WITHOUTomero.group: -1
Test reproduces this but uses
with pytest.raises(omero.SecurityViolation):
to wrap the failing line.Should be removed when the bug is fixed.
Testing this PR
cc @mtbc