Web bugs 18th dec

[will-moore]

Small fixes. To test:

• Admins, when editing users, should not be able remove 'system' group from their list of groups. Now, the 'Administrator' checkbox is the only way to remove 'system' group. This means that when you are editing your OWN profile, you cannot remove your own admin status (by mistake) since the Administrator checkbox is disabled.
• Get a landing page to a well (select well or wells and use the link icon) and paste url into browser. Then select a different item in the tree and re-select the previously selected Plate/Acquisition. Previous bug caused the well(s) specified above to be re-selected automatically (instead of simply selecting the Plate/Acquisition, which is what should happen now).
• Fix tooltip remaining on Batch remove annotations when Tag / File removed. See ticket 9940 for details

[manics]

Removal of System group is prevented for admins, but the X is still shown. If System and Administrator are effectively the same could the System group be hidden, or is that likely to cause confusion?

9940 is fixed.

Opening a ?show=well-6943 link for the first time shows the well as selected, but the right pane shows the plate info instead of the well info.

Multi-well selection is currently broken.

[will-moore]

Hmmm - those last two issues are caused by merging with #545. I'll need to rebase (or something).

Hiding the System group in web-admin would be ideal, but would require a fair bit of work, since E.g. the "default" group is chosen from the list of groups. I was looking for a quick way to prevent the issue. I'll have a go and see if there's a way to hide the X at least.

[will-moore]

@manics To test that last commit (ticket 10004) try removing files / tags from single or multiple selected wells.

[manics]

Multiple well selection still doesn't work.

System group X is still shown when an admin is editting a non-admin user: click on Administrator checkbox, System group appears with an X.

The rest looks good.

[will-moore]

Multi-well selection was a bug in another PR #545. Fixed now.

[manics]

Ready to merge.

[joshmoore]

Thanks, @manics. @will-moore, @pwalczysko, @hflynn, @gusferguson -- anything that needs to be updated w.r.t. docs/scenarios?

[will-moore]

@joshmoore There's only a tiny UI change in webadmin (label "Other Groups" -> "Groups". Others are all minor bug fixes, so I don't think there's any need for docs changes.

[pwalczysko]

@joshmoore, @will-moore, @jburel : the label "Other Groups" - "Groups" was updated in the testing scenarios documentation PR565.

[jburel]

i.e. https://github.com/openmicroscopy/ome-internal/pull/16

[joshmoore]

👍