Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Advanced string formatting #31

Merged
merged 3 commits into from
Apr 7, 2022
Merged

Conversation

ome9ax
Copy link
Owner

@ome9ax ome9ax commented Apr 7, 2022

I added the native 馃悕 Python string formatting for datetime type.
This should cover #20 feature request from @aroder.

@ome9ax ome9ax self-assigned this Apr 7, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2022

Codecov Report

Merging #31 (28ce784) into main (427cc6a) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #31   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          185       191    +6     
  Branches        37        37           
=========================================
+ Hits           185       191    +6     
Flag Coverage 螖
unittests 100.00% <100.00%> (酶)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
target_s3_jsonl/__init__.py 100.00% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 427cc6a...28ce784. Read the comment docs.

@ome9ax ome9ax marked this pull request as ready for review April 7, 2022 10:48
@ome9ax ome9ax merged commit 0f55bfd into main Apr 7, 2022
@ome9ax ome9ax deleted the feature/string_formatting branch April 7, 2022 10:48
@ome9ax ome9ax added the enhancement New feature or request label Apr 7, 2022
@ome9ax ome9ax added this to In progress in Singer Target s3 jsonl via automation Apr 7, 2022
@ome9ax ome9ax moved this from In progress to Done in Singer Target s3 jsonl Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

None yet

2 participants