Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go lint all #316

Merged
merged 9 commits into from Aug 10, 2021
Merged

Go lint all #316

merged 9 commits into from Aug 10, 2021

Conversation

krsna1729
Copy link
Member

Check individual commits for the type of fix. The list of lint issues can found by running -

docker run --rm -v $(pwd)/pfcpiface:/app -w /app golangci/golangci-lint:v1.41.1 \
golangci-lint run -v --enable-all --out-format=tab --max-same-issues=0 --max-issues-per-linter=0

@krsna1729
Fix forbidigo, gci
d61e768 
Signed-off-by: Saikrishna Edupuganti <saikrishna.edupuganti@intel.com>
@krsna1729
Fix goconst
ad82328 
Signed-off-by: Saikrishna Edupuganti <saikrishna.edupuganti@intel.com>
@krsna1729
Fix gocritic:commentFormatting
8886219 
commentFormatting: put a space between `//` and comment text

Signed-off-by: Saikrishna Edupuganti <saikrishna.edupuganti@intel.com>
@krsna1729
Fix error strings should not be capitalized
29338fd 
Signed-off-by: Saikrishna Edupuganti <saikrishna.edupuganti@intel.com>
@krsna1729
Fix godot
c597a06 
Comment should end in a period (default for declarations only)

Signed-off-by: Saikrishna Edupuganti <saikrishna.edupuganti@intel.com>
@krsna1729
Fix File is not gofumpt-ed
bb71d7d 
Run

```
gofumpt -l -w .
```

Signed-off-by: Saikrishna Edupuganti <saikrishna.edupuganti@intel.com>
@krsna1729
Fix unconvert
ff099db 
Remove unnecessary conversions

Signed-off-by: Saikrishna Edupuganti <saikrishna.edupuganti@intel.com>
@krsna1729
Fix whitespace
c14c34b 
Remove unnecessary trailing newline

Signed-off-by: Saikrishna Edupuganti <saikrishna.edupuganti@intel.com>
@krsna1729
Fix wsl lint
f13479c 
It really doesn't like cuddling

Signed-off-by: Saikrishna Edupuganti <saikrishna.edupuganti@intel.com>
@krsna1729
Copy link
Member Author 

docker run --rm -v $(pwd)/pfcpiface:/app -w /app golangci/golangci-lint:v1.41.1 \
golangci-lint run -v --enable-all --disable=nlreturn --out-format=tab --max-same-issues=0 --max-issues-per-linter=0

disabling nlreturn as wsl seems better with returns in blocks of 2 lines

@krsna1729 krsna1729 marked this pull request as ready for review August 10, 2021 15:03
badhrinathpa
badhrinathpa approved these changes Aug 10, 2021
View reviewed changes
Copy link
Contributor

@badhrinathpa badhrinathpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@badhrinathpa badhrinathpa merged commit 8a0a396 into master Aug 10, 2021
@badhrinathpa badhrinathpa deleted the go-lint-all branch August 10, 2021 19:38
@krsna1729 krsna1729 mentioned this pull request Dec 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@badhrinathpa badhrinathpa badhrinathpa approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@krsna1729 @badhrinathpa