Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go lint all #316

Merged
merged 9 commits into from
Aug 10, 2021
Merged

Go lint all #316

merged 9 commits into from
Aug 10, 2021

Commits on Aug 10, 2021

  1. Fix forbidigo, gci 

    Signed-off-by: Saikrishna Edupuganti <saikrishna.edupuganti@intel.com>
    @krsna1729
    krsna1729 committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    d61e768 View commit details
    Browse the repository at this point in the history

  2. Fix goconst 

    Signed-off-by: Saikrishna Edupuganti <saikrishna.edupuganti@intel.com>
    @krsna1729
    krsna1729 committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    ad82328 View commit details
    Browse the repository at this point in the history

  3. Fix gocritic:commentFormatting 

    commentFormatting: put a space between `//` and comment text

Signed-off-by: Saikrishna Edupuganti <saikrishna.edupuganti@intel.com>
    @krsna1729
    krsna1729 committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    8886219 View commit details
    Browse the repository at this point in the history

  4. Fix error strings should not be capitalized 

    Signed-off-by: Saikrishna Edupuganti <saikrishna.edupuganti@intel.com>
    @krsna1729
    krsna1729 committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    29338fd View commit details
    Browse the repository at this point in the history

  5. Fix godot 

    Comment should end in a period (default for declarations only)

Signed-off-by: Saikrishna Edupuganti <saikrishna.edupuganti@intel.com>
    @krsna1729
    krsna1729 committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    c597a06 View commit details
    Browse the repository at this point in the history

  6. Fix File is not gofumpt-ed 

    Run

```
gofumpt -l -w .
```

Signed-off-by: Saikrishna Edupuganti <saikrishna.edupuganti@intel.com>
    @krsna1729
    krsna1729 committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    bb71d7d View commit details
    Browse the repository at this point in the history

  7. Fix unconvert 

    Remove unnecessary conversions

Signed-off-by: Saikrishna Edupuganti <saikrishna.edupuganti@intel.com>
    @krsna1729
    krsna1729 committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    ff099db View commit details
    Browse the repository at this point in the history

  8. Fix whitespace 

    Remove unnecessary trailing newline

Signed-off-by: Saikrishna Edupuganti <saikrishna.edupuganti@intel.com>
    @krsna1729
    krsna1729 committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    c14c34b View commit details
    Browse the repository at this point in the history

  9. Fix wsl lint 

    It really doesn't like cuddling

Signed-off-by: Saikrishna Edupuganti <saikrishna.edupuganti@intel.com>
    @krsna1729
    krsna1729 committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    f13479c View commit details
    Browse the repository at this point in the history