-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFE#1714] chore: build languagetool as modules #741
[RFE#1714] chore: build languagetool as modules #741
Conversation
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Review points file
|
To allow download LT separately, #226 is required. |
TODO:
|
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spotted a few typos.
languagetools/src/fa/java/org/omegat/languagetool/language/PercianPlugin.java
Outdated
Show resolved
Hide resolved
languagetools/src/gl/java/org/omegat/languagetool/language/GalcianPlugin.java
Outdated
Show resolved
Hide resolved
and add comment line for string match stratgy Signed-off-by: Hiroshi Miura <miurahr@linux.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now.
I found that a source distribution has unwanted library jar files. It may be caused by a filter of "*RuntimeClasspath" that may include dependencies of Gradle plugins such as SpotBugs dependency. |
This caused from dependency jStyleParser library. I'd like to fix the issue in another PR. |
This reverts commit 7a3a77f. There is a report that modularize of langaugetool does not work.
Languagetools language libraries are optional for OmegaT application.
This proposal changes these libraries as module.
In future, we will distribute these modules as optional plugin packages when #226 merged.
Pull request type
Which ticket is resolved?
What does this PR change?
languagetools
omegat-language-XX.jar
in build/modulesOther information
dev-ML discussion suggests