-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: call MenuHandlers without reflection #983
refactor: call MenuHandlers without reflection #983
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
d0ed739
to
e4248fe
Compare
rebased on current master. |
This comment was marked as resolved.
This comment was marked as resolved.
cb48713
to
80bf094
Compare
Now ready for merge. |
- refactor exit actions menus Signed-off-by: Hiroshi Miura <miurahr@linux.com>
09ebd74
to
65a7db0
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
- set default implementation of invokeAction interface with nothing - Remove deprecated method from test overrides Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
❌ Unit Tests, Quality checks, and Acceptance Tests failed. Please look a Gradle Scan page for details: |
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
74ac6c6
to
cb53607
Compare
❌ Unit Tests, Quality checks, and Acceptance Tests failed. Please look a Gradle Scan page for details: |
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
- Fix NPE: call parent frame in initalization - move Handler common method to ProjectUICommands Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
❌ Unit Tests, Quality checks, and Acceptance Tests failed. Please look a Gradle Scan page for details: |
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
❌ Unit Tests, Quality checks, and Acceptance Tests failed. Please look a Gradle Scan page for details: |
This reverts commit 13d60e7.
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
❌ Unit Tests, Quality checks, and Acceptance Tests failed. Please look a Gradle Scan page for details: |
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
❌ Unit Tests, Quality checks, and Acceptance Tests failed. Please look a Gradle Scan page for details: |
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
❌ Unit Tests, Quality checks, and Acceptance Tests failed. Please look a Gradle Scan page for details: |
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
❌ Unit Tests, Quality checks, and Acceptance Tests failed. Please look a Gradle Scan page for details: |
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
❌ Unit Tests, Quality checks, and Acceptance Tests failed. Please look a Gradle Scan page for details: |
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
❌ Unit Tests, Quality checks, and Acceptance Tests failed. Please look a Gradle Scan page for details: |
refactor MainWindowMenuHandler and MainWindowMenu not to use reflection to invoke action. Otherwise, we use
Action
interface appeared in Java 1.6.OmegaT project have not used it, because lib-mnemonics does not support
Action
interface in previous versions.Now lib-mnemonics library version 1.2 adds
AbstractmnemonicsAction
class that help application defineActon
with mnemonics.Pull request type
refactor
Which ticket is resolved?
dev-ML https://sourceforge.net/p/omegat/mailman/message/58749145/
What does this PR change?
MainWindowMenuHandler#braBrabrahActionperformed
method withAction
classes that extends withAbstractMnemonicAction
classBaseMainWindowMenu
to useAction
class to construct UI components.Other information
Implementation depends on lib-mnemonics enhancement
omegat-org/lib-mnemonics#8