Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: call MenuHandlers without reflection #983

Closed
wants to merge 35 commits into from
Closed

refactor: call MenuHandlers without reflection #983

wants to merge 35 commits into from

Commits on May 25, 2024

  1. feat: MenuHanlder actions with AbstractAction 

    - refactor exit actions menus

Signed-off-by: Hiroshi Miura <miurahr@linux.com>
    @miurahr
    miurahr committed May 25, 2024
    Configuration menu
    Copy the full SHA
    65a7db0 View commit details
    Browse the repository at this point in the history

  2. wip 

    Signed-off-by: Hiroshi Miura <miurahr@linux.com>
    @miurahr
    miurahr committed May 25, 2024
    Configuration menu
    Copy the full SHA
    db5820c View commit details
    Browse the repository at this point in the history

  3. refactor: AccessTools constructor 

    Signed-off-by: Hiroshi Miura <miurahr@linux.com>
    @miurahr
    miurahr committed May 25, 2024
    Configuration menu
    Copy the full SHA
    5021ff7 View commit details
    Browse the repository at this point in the history

  4. refactor: IMainMenu#invokeAction 

    - set default implementation of invokeAction interface
  with nothing
- Remove deprecated method from test overrides

Signed-off-by: Hiroshi Miura <miurahr@linux.com>
    @miurahr
    miurahr committed May 25, 2024
    Configuration menu
    Copy the full SHA
    b067c1b View commit details
    Browse the repository at this point in the history

  5. refactor: Log menu selection for debug 

    Signed-off-by: Hiroshi Miura <miurahr@linux.com>
    @miurahr
    miurahr committed May 25, 2024
    Configuration menu
    Copy the full SHA
    89692d0 View commit details
    Browse the repository at this point in the history

  6. refactor: invokeAction to invoke Action object 

    Signed-off-by: Hiroshi Miura <miurahr@linux.com>
    @miurahr
    miurahr committed May 25, 2024
    Configuration menu
    Copy the full SHA
    c9ca4b1 View commit details
    Browse the repository at this point in the history

  7. feat: menu actions (wip) 

    Signed-off-by: Hiroshi Miura <miurahr@linux.com>
    @miurahr
    miurahr committed May 25, 2024
    Configuration menu
    Copy the full SHA
    c5b3b43 View commit details
    Browse the repository at this point in the history

  8. feat: MainWindowMenu deprecate old menu creation methods 

    Signed-off-by: Hiroshi Miura <miurahr@linux.com>
    @miurahr
    miurahr committed May 25, 2024
    Configuration menu
    Copy the full SHA
    cb53607 View commit details
    Browse the repository at this point in the history

  9. fix: logging component names 

    Signed-off-by: Hiroshi Miura <miurahr@linux.com>
    @miurahr
    miurahr committed May 25, 2024
    Configuration menu
    Copy the full SHA
    0f0b835 View commit details
    Browse the repository at this point in the history

  10. fix: define missing menu action 

    Signed-off-by: Hiroshi Miura <miurahr@linux.com>
    @miurahr
    miurahr committed May 25, 2024
    Configuration menu
    Copy the full SHA
    459d213 View commit details
    Browse the repository at this point in the history

  11. style: apply spotless 

    Signed-off-by: Hiroshi Miura <miurahr@linux.com>
    @miurahr
    miurahr committed May 25, 2024
    Configuration menu
    Copy the full SHA
    10bf490 View commit details
    Browse the repository at this point in the history

  12. style: suppress MainWindowMenuHandler file length warning 

    Signed-off-by: Hiroshi Miura <miurahr@linux.com>
    @miurahr
    miurahr committed May 25, 2024
    Configuration menu
    Copy the full SHA
    9ead61b View commit details
    Browse the repository at this point in the history

Commits on May 26, 2024

  1. refactor: menu class constructor to be default 

    - define default constructor of MainWindowMenu
- define default constructor of BaseMainWindowMenu
- define default constructor of MainWindowMenu
- define default constructor of TestCoreGUI.TestMainWindowMenu

- Replace mainWindow object access with Core.getMainWindow function
- Set Menu name with titleKey
- Set MenuItem name with action command
- Not to create menu handler instance in MainWindow class
- Update object creation of menu class with default constructor

Signed-off-by: Hiroshi Miura <miurahr@linux.com>
    @miurahr
    miurahr committed May 26, 2024
    Configuration menu
    Copy the full SHA
    cd9aa4d View commit details
    Browse the repository at this point in the history

  2. fix: remove an unwanted change 

    Signed-off-by: Hiroshi Miura <miurahr@linux.com>
    @miurahr
    miurahr committed May 26, 2024
    Configuration menu
    Copy the full SHA
    43ef472 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. refactor: direct instantiate Action classes 

    Signed-off-by: Hiroshi Miura <miurahr@linux.com>
    @miurahr
    miurahr committed May 28, 2024
    Configuration menu
    Copy the full SHA
    1c61262 View commit details
    Browse the repository at this point in the history

  2. style: default constructor 

    Signed-off-by: Hiroshi Miura <miurahr@linux.com>
    @miurahr
    miurahr committed May 28, 2024
    Configuration menu
    Copy the full SHA
    0e0edca View commit details
    Browse the repository at this point in the history

  3. style: private default constructor 

    Signed-off-by: Hiroshi Miura <miurahr@linux.com>
    @miurahr
    miurahr committed May 28, 2024
    Configuration menu
    Copy the full SHA
    c9ab3c3 View commit details
    Browse the repository at this point in the history

  4. style: menu action logging in single line 

    Signed-off-by: Hiroshi Miura <miurahr@linux.com>
    @miurahr
    miurahr committed May 28, 2024
    Configuration menu
    Copy the full SHA
    4f7b238 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. fix: action command str equals field name for shortcut key assign 

    Signed-off-by: Hiroshi Miura <miurahr@linux.com>
    @miurahr
    miurahr committed May 29, 2024
    Configuration menu
    Copy the full SHA
    e9d2ae0 View commit details
    Browse the repository at this point in the history

  2. feat: set shortcut key to Action object 

    Signed-off-by: Hiroshi Miura <miurahr@linux.com>
    @miurahr
    miurahr committed May 29, 2024
    Configuration menu
    Copy the full SHA
    3bab572 View commit details
    Browse the repository at this point in the history

  3. fix: drop action listener in BaseMainWindowMenu 

    Signed-off-by: Hiroshi Miura <miurahr@linux.com>
    @miurahr
    miurahr committed May 29, 2024
    Configuration menu
    Copy the full SHA
    d05b66b View commit details
    Browse the repository at this point in the history

  4. fix: NPE and refactor 

    - Fix NPE: call parent frame in initalization
- move Handler common method to ProjectUICommands

Signed-off-by: Hiroshi Miura <miurahr@linux.com>
    @miurahr
    miurahr committed May 29, 2024
    Configuration menu
    Copy the full SHA
    63decb6 View commit details
    Browse the repository at this point in the history

  5. fix: duplicated UI component initialization 

    Signed-off-by: Hiroshi Miura <miurahr@linux.com>
    @miurahr
    miurahr committed May 29, 2024
    Configuration menu
    Copy the full SHA
    9e78061 View commit details
    Browse the repository at this point in the history

  6. refactor: import actions sub classes 

    Signed-off-by: Hiroshi Miura <miurahr@linux.com>
    @miurahr
    miurahr committed May 29, 2024
    Configuration menu
    Copy the full SHA
    a12a52c View commit details
    Browse the repository at this point in the history

  7. style: suppress star import of a hundred of actions 

    Signed-off-by: Hiroshi Miura <miurahr@linux.com>
    @miurahr
    miurahr committed May 29, 2024
    Configuration menu
    Copy the full SHA
    f85d470 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. refactor: SearchWindowMenu uses Action in MainMenuHandler 

    Signed-off-by: Hiroshi Miura <miurahr@linux.com>
    @miurahr
    miurahr committed May 31, 2024
    Configuration menu
    Copy the full SHA
    18b84d4 View commit details
    Browse the repository at this point in the history

  2. refactor: MainMenuHandler to move helpers to ProjectUICommands 

    Signed-off-by: Hiroshi Miura <miurahr@linux.com>
    @miurahr
    miurahr committed May 31, 2024
    Configuration menu
    Copy the full SHA
    58ea3fd View commit details
    Browse the repository at this point in the history

  3. refactor: GlossaryTextArea to use Actions classes 

    Signed-off-by: Hiroshi Miura <miurahr@linux.com>
    @miurahr
    miurahr committed May 31, 2024
    Configuration menu
    Copy the full SHA
    13d60e7 View commit details
    Browse the repository at this point in the history

  4. Revert "refactor: GlossaryTextArea to use Actions classes" 

    This reverts commit 13d60e7.
    @miurahr
    miurahr committed May 31, 2024
    Configuration menu
    Copy the full SHA
    9110727 View commit details
    Browse the repository at this point in the history

  5. revert change 

    Signed-off-by: Hiroshi Miura <miurahr@linux.com>
    @miurahr
    miurahr committed May 31, 2024
    Configuration menu
    Copy the full SHA
    bdbfc60 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2024

  1. style: add serialVersionUID for actions 

    Signed-off-by: Hiroshi Miura <miurahr@linux.com>
    @miurahr
    miurahr committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    4b10ca5 View commit details
    Browse the repository at this point in the history

  2. revert other text area changes 

    Signed-off-by: Hiroshi Miura <miurahr@linux.com>
    @miurahr
    miurahr committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    9c535fc View commit details
    Browse the repository at this point in the history

  3. refactor: JButton constructor takes Action object 

    Signed-off-by: Hiroshi Miura <miurahr@linux.com>
    @miurahr
    miurahr committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    6ccb5f5 View commit details
    Browse the repository at this point in the history

  4. fix: replace invokeAction with alternative 

    Signed-off-by: Hiroshi Miura <miurahr@linux.com>
    @miurahr
    miurahr committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    95f9427 View commit details
    Browse the repository at this point in the history

  5. revert SearchWindowMenu chages 

    Signed-off-by: Hiroshi Miura <miurahr@linux.com>
    @miurahr
    miurahr committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    ffe1c3d View commit details
    Browse the repository at this point in the history