Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Every form in the plugins list creates a hidden input with a "csrf_token" id #721

Open
kimisgold opened this issue Jul 13, 2016 · 4 comments
Labels

Comments

@kimisgold
Copy link
Member

Each of these inputs should have unique ids.

@patrickmj
Copy link
Contributor

Do you mean on the admin plugins page? Or plugins adding their inputs to, e.g., the item edit tabs?

@kimisgold
Copy link
Member Author

Admin plugins browse.

On Wednesday, July 13, 2016, Patrick Murray-John notifications@github.com
wrote:

Do you mean on the admin plugins page? Or plugins adding their inputs to,
e.g., the item edit tabs?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#721 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAlCLGiIkfgnv2c6FocvHybMVGfDd9fmks5qVPQcgaJpZM4JK_44
.

Kim Nguyen
Web Designer
Roy Rosenzweig Center for History and New Media

@patrickmj
Copy link
Contributor

ugh. yeah. now i see it

@kimisgold kimisgold removed the a11y label Jul 13, 2016
@zerocrates
Copy link
Member

The only simple way to fix this is to trade one validation problem for another: we can get Zend's form code to output a blank-string ID, but not to omit it entirely. In practice the browsers uniformly seem to ignore blank IDs, but it is a violation of the standard (see #701).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants