Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using addElementToSaveGroup creates visual issue #981

Closed
DBinaghi opened this issue Jul 19, 2022 · 1 comment
Closed

Using addElementToSaveGroup creates visual issue #981

DBinaghi opened this issue Jul 19, 2022 · 1 comment

Comments

@DBinaghi
Copy link
Contributor

It seems that following the Best Practices suggestion to use addElementToSaveGroup to insert elements in the Save side panel is creating an issue with sizes: getSaveGroupDefaultElementDecorators function inserts an extra div (with class=“field”) to contain the button, and the field.input css style cause it to resize width to calc(5/7 * 100%).

As there should be no need to resize buttons or other controls inside the side panels, width should be probably maintained to 100%.

Please see https://forum.omeka.org/t/addelementtosavegroup-creates-visual-issue/15374 for more details.

@zerocrates
Copy link
Member

This should be fixed on the master branch since the referenced commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants