Adds options param to javascript queue functions. #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an option parameter to `queue_js_file` and `queue_js_string` to allow for, among other things, wrapping the outputs of those with conditional comments similar to the CSS queue functions. Other options can be passed as well, per the Zend Framework documentation for headScript: http://framework.zend.com/manual/1.12/en/zend.view.helpers.html#zend.view.helpers.initial.headscript Updates the test that shall not be named to check for these conditional comments.
|
In writing the tests, I tried to include a check using |
zerocrates
added a commit
that referenced
this pull request
Nov 5, 2012
Adds options param to javascript queue functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option parameter to
queue_js_fileandqueue_js_stringto allowfor, among other things, wrapping the outputs of those with conditional
comments similar to the CSS queue functions.
Other options can be passed as well, per the Zend Framework documentation for
headScript.
Updates the test that shall not be named to check for these conditional
comments.