Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addd block layout template for page title #1787

Merged
merged 2 commits into from Dec 13, 2021
Merged

Conversation

grandgeorg
Copy link
Contributor

@grandgeorg grandgeorg commented Dec 2, 2021

The page title for sites was hardcoded to H2.
Now one can change it to suit their needs.

The page title for sites was hardcoded to H2.
Now one can change it to suite their needs.
@zerocrates
Copy link
Member

Seems like a perfectly good idea, just to enable theme overriding here.

One note: I think you should pass the title unescaped and then escape it in the view. Just to make anything else a view might want to do with the unescaped title easier, and to align with most of our other usage where the theme does the escaping.

Title is passed unescaped. Escaping takes place in the view.
@grandgeorg
Copy link
Contributor Author

Done as recommended.

@zerocrates zerocrates merged commit ba3734b into omeka:develop Dec 13, 2021
@zerocrates
Copy link
Member

Thanks.

@Daniel-KM
Copy link
Contributor

There are many things from the module Block Plus (or other modules) that are regularly implemented in core. Is it a good idea if I add some pull requests for some of features? In fact, the perimeter of the core and the modules is not clear. Is there a place where it is defined?

@zerocrates
Copy link
Member

I don't have a hard and fast rule for you on the boundary of what makes sense in the core vs. modules... I kind of take things on a case by case basis.

I can think of some categories of things that make us think things shouldn't be included, like if they seem like they will be difficult to maintain, or not broadly applicable to users, or incompatible, things like that. But I'm sure there are many improvements to the core's features that are currently in modules that we could/would accept.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants