Fix/translate aria label #2120
Fix/translate aria label #2120
Conversation
| @@ -10,6 +10,8 @@ public function __invoke(ContainerInterface $container, $name, | |||
| callable $callback, array $options = null | |||
| ) { | |||
| $formSelect = $callback(); | |||
| $formSelect->addTranslatableAttribute('aria-label'); | |||
| $formSelect->addTranslatableAttribute('title'); | |||
There was a problem hiding this comment.
title is a default translatable attribute defined in the Laminas abstract form view helper so I don't believe this line is needed
| @@ -48,7 +48,7 @@ public function __invoke($partialName = null, array $query = null) | |||
| switch ($key) { | |||
| // Fulltext | |||
| case 'fulltext_search': | |||
| $filterLabel = $translate('Search full-text'); | |||
| $filterLabel = $translate('Search full-text'); // @translate | |||
There was a problem hiding this comment.
$translate calls are detected by xgettext, so they don't need the @translate comment.
Generally the comment is only needed where the string literal is not used directly in a call to $translate or $this->translate.
There was a problem hiding this comment.
Same comment applies to all the changes in this file, I believe
|
I made the requested change on |
No description provided.