Fixed error logging bug

omgimanerd · Aug 9, 2017 · 71dc441 · 71dc441
1 parent 9a86370
commit 71dc441
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/server/api.js b/server/api.js
@@ -131,8 +131,8 @@ const fetchArticles = source => {
     }
     return results
   }).catch(error => {
-    return errorBuilder.promise('NewsAPIArticlesShorteningError',
-        error.error ? error.error : error)
+    return error.error ? errorBuilder.promise('NewsAPIArticlesShorteningError',
+        error.error) : error
   })
 }
 

diff --git a/server/loggers.js b/server/loggers.js
@@ -21,7 +21,7 @@ module.exports = exports = (options) => {
   if (PROD_MODE && (!USERNAME || !PASSWORD || !ALERT_EMAIL)) {
     throw new Error('Production configuration not provided!')
   }
-  
+
   const analyticsFile = options.analyticsFile
   const errorFile = options.errorFile
 
@@ -41,7 +41,7 @@ module.exports = exports = (options) => {
       host: 'smtp.gmail.com',
       username: USERNAME,
       password: PASSWORD,
-      subject: 'NYCURL ERROR',
+      subject: 'GETNEWS.TECH ERROR',
       ssl: true
     }))
   }
@@ -69,7 +69,9 @@ module.exports = exports = (options) => {
       colorize: true,
       dynamicMeta: dynamicMetaFunction
     }),
-    errorLogger: expressWinston.errorLogger({
+    // We are using a plain winston logger here because we will invoke this
+    // logger's logging methods manually instead of using it as middleware.
+    errorLogger: new winston.Logger({
       transports: errorTransports
     })
   }