rename statsd env to DD_HOSTNAME/DD_PORT #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InoMurko
suggested changes
Jul 17, 2019
following datadog env names: https://docs.datadoghq.com/agent/docker/?tab=standard#global-options
InoMurko
approved these changes
Jul 18, 2019
chrishunt
approved these changes
Jul 18, 2019
achiurizo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃搵 Conversation with devops
馃搵 https://github.com/omisego/devops/pull/116
Overview
Changing our ENVVAR to instead to
DD. The concern was that by naming it explicitly, this will help prevent confusion in the future in what this is pointing to for us.This will still work with regular
statsd, Open to suggestions.Changes
Changes
STATSD_HOST->DD_HOSTNAMEChanges
STATSD_PORT->DD_PORTTesting
N/A
Describe how to test your new feature/bug fix and if possible, a step by step guide on how to demo this.