Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add advanced filter #108

Merged
merged 8 commits into from
Jan 8, 2019
Merged

Add advanced filter #108

merged 8 commits into from
Jan 8, 2019

Conversation

mederic-p
Copy link
Contributor

@mederic-p mederic-p commented Nov 2, 2018

Issue/Task Number: 107
Closes #107

Overview

This PR adds the new filters introduced in #440 and #486.

Changes

  • Remove the deprecated searchTerm and searchTerms
  • Add a new Filterable protocol to which paginated collection can conform in order to generate FilterParams.

Implementation Details

The implementation follows the advanced filtering guide and provide some helpers to simplify filter creation.

Each filterable resources now have a predefined set of filterable fields to make it easier for the developers to filter simple relations. However we still allow a more advanced filtering where developers can specify the field path as a string.

Usage

The full usage is documented in this documentation file.

Impact

searchTerm and searchTerms are now removed and developers need to conform to the new filtering system.

@ghost ghost added the s2/wip 🚧 This is still being worked on label Nov 2, 2018
@T-Dnzt T-Dnzt removed their assignment Nov 20, 2018
@mederic-p mederic-p merged commit 5b94f54 into master Jan 8, 2019
@mederic-p mederic-p deleted the 107-filters branch January 8, 2019 04:14
@ghost ghost removed the s2/wip 🚧 This is still being worked on label Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants